Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RHOAIENG-15495): Add component metadata manifest #374

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat(RHOAIENG-15495): Add component metadata manifest #374

merged 2 commits into from
Dec 2, 2024

Conversation

ruivieira
Copy link
Member

Refer to RHOAIENG-15495

Add template component_metadata to be populated with release values when performing community releases.

@ruivieira ruivieira added the kind/enhancement New feature or request label Nov 29, 2024
@ruivieira ruivieira self-assigned this Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:a2f17d651f75504f6fb901849109e1c91058cd34

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:a2f17d651f75504f6fb901849109e1c91058cd34

📦 LMES job image: quay.io/trustyai/ta-lmes-job:a2f17d651f75504f6fb901849109e1c91058cd34

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-a2f17d651f75504f6fb901849109e1c91058cd34

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 29, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e a2f17d6 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielezonca
Copy link
Member

to be populated with release values when performing community releases

Do you plan to make this automatic?

@openshift-ci openshift-ci bot added the lgtm label Nov 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielezonca, RobGeada

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira
Copy link
Member Author

to be populated with release values when performing community releases

Do you plan to make this automatic?

@danielezonca I could include some automation in a future PR. Perhaps getting the values from the release branch name? I think it's better than tag-based, since in that case the changes would happen after the tag is pushed.

@ruivieira ruivieira merged commit c9467b5 into trustyai-explainability:main Dec 2, 2024
6 of 8 checks passed
ruivieira added a commit that referenced this pull request Dec 11, 2024
@ruivieira
feat(RHOAIENG-15495): Add component metadata manifest (#374)
be902d3 
* feat(RHOAIENG-15495): Add component metadata manifest

Refer to [RHOAIENG-15495](https://issues.redhat.com/browse/RHOAIENG-15495)

* Add new line to fix linting

(cherry picked from commit c9467b5)
@ruivieira ruivieira mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobGeada RobGeada RobGeada approved these changes

@danielezonca danielezonca danielezonca approved these changes

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder

@christinaexyou christinaexyou Awaiting requested review from christinaexyou

@m-misiura m-misiura Awaiting requested review from m-misiura

Assignees

@danielezonca danielezonca

@ruivieira ruivieira

@RobGeada RobGeada

Labels
kind/enhancement New feature or request lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruivieira @danielezonca @RobGeada